io_improvement #7

Merged

madrigal merged 3 commits from io_improvement into main 2025-10-22 11:16:19 -04:00

Conversation 0 Commits 3 Files Changed 3 +95 -52

M

M madrigal commented 2025-10-22 10:56:31 -04:00

Member

Copy Link

• added overwrite protection to Recording's to_npy and to_sigmf methods
  • now, users can set overwrite=True, but by default if the file already exists, an IOError will be raised
• moved generate_filename out of data.recording.py and into io.recording.py

- added overwrite protection to Recording's to_npy and to_sigmf methods - now, users can set overwrite=True, but by default if the file already exists, an IOError will be raised - moved generate_filename out of data.recording.py and into io.recording.py

madrigal added 2 commits 2025-10-22 10:56:31 -04:00

M Created file overwrite protections in to_npy and to_sigmf d68b9727ad

M Moved auto filename generator from data.recording to io.recording ddf445fd4d

madrigal added 1 commit 2025-10-22 11:01:56 -04:00

M Fixed test_sigmf_2 4420ae76c9

M madrigal requested review from benchinnery 2025-10-22 11:03:28 -04:00

benchinnery approved these changes 2025-10-22 11:14:06 -04:00

benchinnery left a comment

Owner

Copy Link

Looks good, I also have some changes on the way for recording file logic so we should test before making next release. But seems all good on my end

Looks good, I also have some changes on the way for recording file logic so we should test before making next release. But seems all good on my end

M madrigal merged commit 5074e8f32a into main 2025-10-22 11:16:19 -04:00

M madrigal referenced this issue from a commit 2025-10-22 11:16:20 -04:00

Merge pull request 'io_improvement' (#7) from io_improvement into main

M madrigal deleted branch io_improvement 2025-10-22 11:16:24 -04:00

Sign in to join this conversation.

Reviewers

No reviewers

benchinnery

Labels

Clear labels

  

CI/CD 🛠️

This issue relates to our automated testing, building, and publishing processes

  

WIP 🚧

Someone is currently worked on this issue

  

bug 🐞

There is a problem, error, or unexpected behaviour

  

code quality 🧹

This issues pertains to code quality improvements or tech debt reduction

  

data collection 🗃️

This issue involves machine learning data collection or filing

  

dependency 📦

This issue pertains to dependency changes or deprecation warnings

  

do not merge 🚫

This pull request is not to be merged

  

documentation 📝

Improvements or additions to documentation or tutorials

  

duplicate 🔄

This issue or pull request already exists

  

enhancement ✨

This issue is important and will require attention soon, but does not pose any immediate risks

  

good first issue 🌱

A good first issue for newcomers

  

help wanted 👋

Additional development support is required

  

inference 🧠

This issue involves designing or improving inference solutions

  

invalid 🛑

Something is wrong with this issue or it not does conform to project guidelines

  

machine learning 🚀

This issue pertains to and may require expertise in machine learning

  

priority

high🔥

This issue is critical and requires immediate attention to prevent further consequence or escalation

  

priority

low 🍃

  

priority

medium 🌟

This issue is important and will require attention soon, but does not pose any immediate risks

  

quantum ⚛️

This issue pertains to and may require expertise in quantum technology

  

question ❓

Additional information is required

  

radio 📡

This issue involves radio interface components and may requires access to radio hardware

  

sprintable 🏃‍♂️

This issue could be resolved in a single sprint

  

test 🧪

This issue pertains to our testing efforts

  

wont fix ❌

We've chosen not to address this issue

No Label

CI/CD 🛠️

WIP 🚧

bug 🐞

code quality 🧹

data collection 🗃️

dependency 📦

do not merge 🚫

documentation 📝

duplicate 🔄

enhancement ✨

good first issue 🌱

help wanted 👋

inference 🧠

invalid 🛑

machine learning 🚀

priority

high🔥

priority

low 🍃

priority

medium 🌟

quantum ⚛️

question ❓

radio 📡

sprintable 🏃‍♂️

test 🧪

wont fix ❌

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

M

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: qoherent/ria-toolkit-oss#7

No description provided.