annotationsfix #19

Merged
madrigal merged 23 commits from annotationsfix into main 2026-04-20 15:57:23 -04:00

23 Commits

Author SHA1 Message Date
ben
db000da517 Add noqa C901 to view() to pass flake8 complexity check
All checks were successful
Build Sphinx Docs Set / Build Docs (pull_request) Successful in 17m39s
Build Project / Build Project (3.10) (pull_request) Successful in 18m13s
Build Project / Build Project (3.12) (pull_request) Successful in 8m42s
Build Project / Build Project (3.11) (pull_request) Successful in 9m2s
Test with tox / Test with tox (3.10) (pull_request) Successful in 4m34s
Test with tox / Test with tox (3.12) (pull_request) Successful in 5m27s
Test with tox / Test with tox (3.11) (pull_request) Successful in 17m4s
2026-04-20 15:08:31 -04:00
d6c66d2a07 Merge branch 'main' of https://riahub.ai/qoherent/ria-toolkit-oss into annotationsfix
Some checks failed
Build Sphinx Docs Set / Build Docs (pull_request) Successful in 3m24s
Test with tox / Test with tox (3.11) (pull_request) Successful in 4m22s
Test with tox / Test with tox (3.10) (pull_request) Failing after 5m51s
Test with tox / Test with tox (3.12) (pull_request) Successful in 6m37s
Build Project / Build Project (3.10) (pull_request) Successful in 15m30s
Build Project / Build Project (3.12) (pull_request) Successful in 18m52s
Build Project / Build Project (3.11) (pull_request) Successful in 19m20s
2026-04-20 14:38:57 -04:00
Mmuq
d3a7e9ef0f Resolve merge conflict: keep Pass 2 spillover fix over remote's buggy version
Some checks failed
Build Sphinx Docs Set / Build Docs (pull_request) Successful in 18s
Build Project / Build Project (3.12) (pull_request) Successful in 3m21s
Test with tox / Test with tox (3.11) (pull_request) Successful in 3m24s
Build Project / Build Project (3.11) (pull_request) Successful in 3m35s
Build Project / Build Project (3.10) (pull_request) Successful in 3m37s
Test with tox / Test with tox (3.10) (pull_request) Failing after 4m6s
Test with tox / Test with tox (3.12) (pull_request) Successful in 4m25s
Remote annotationsfix had a partial port of threshold_qualifier without
the Pass 2 hysteresis spillover fix. Kept our corrected version in both
conflicting sections:
- Pass 2 mask expanded by window_size guard band around Pass 1 ranges
- Pass 2 expansion runs against residual_power instead of smoothed_power
2026-04-20 12:22:46 -04:00
Mmuq
93ae08bc91 Port threshold_qualifier improvements and Pass 2 spillover fix from utils
The OSS threshold_qualifier was last synced from utils on Feb 23 2026,
before the major robustness improvements landed in utils on Mar 19 2026.
This commit brings it fully up to date.

Changes ported from utils:
- Multi-pass detection (Pass 1 strong burst, Pass 2 weak residual,
  Pass 3 sustained faint burst via macro-window averaging)
- Noise floor estimation via percentile instead of simple max*threshold
- Dynamic range ratio guard (early exit on low-contrast captures)
- Improved _find_ranges, _expand_and_filter_ranges, _merge_ranges helpers
- Spectral smoothing in _estimate_spectral_bounds for wideband bursts
- Minimum duration filter expressed in absolute time (5ms) not sample count

Also includes the Pass 2 hysteresis spillover fix:
- Pass 2 expansion now runs against residual_power (masked) instead of
  smoothed_power, preventing it from walking into Pass 1 territory
- Pass 2 mask now has a window_size guard band around Pass 1 ranges,
  matching the guard already used in Pass 3

Only change from utils: import swapped to ria_toolkit_oss.datatypes.
2026-04-20 12:11:05 -04:00
1005228d69 Linting and updated poetry.lock
Some checks failed
Build Sphinx Docs Set / Build Docs (pull_request) Successful in 15m55s
Build Project / Build Project (3.10) (pull_request) Successful in 59s
Build Project / Build Project (3.11) (pull_request) Successful in 58s
Build Project / Build Project (3.12) (pull_request) Successful in 56s
Test with tox / Test with tox (3.12) (pull_request) Successful in 1m4s
Test with tox / Test with tox (3.11) (pull_request) Successful in 3m8s
Test with tox / Test with tox (3.10) (pull_request) Failing after 46s
2026-04-02 11:07:12 -04:00
3eb084bc08 Merge branch 'main' of https://riahub.ai/qoherent/ria-toolkit-oss into annotationsfix
Some checks failed
Test with tox / Test with tox (3.12) (pull_request) Failing after 0s
Build Sphinx Docs Set / Build Docs (pull_request) Successful in 15s
Build Project / Build Project (3.10) (pull_request) Successful in 57s
Build Project / Build Project (3.11) (pull_request) Successful in 56s
Build Project / Build Project (3.12) (pull_request) Successful in 55s
Test with tox / Test with tox (3.11) (pull_request) Failing after 12s
Test with tox / Test with tox (3.10) (pull_request) Failing after 23s
2026-04-02 11:00:42 -04:00
c7b88f1f14 Fixed import typo
Some checks failed
Build Sphinx Docs Set / Build Docs (pull_request) Failing after 1m56s
Build Project / Build Project (3.11) (pull_request) Failing after 1m54s
Build Project / Build Project (3.12) (pull_request) Failing after 5s
Test with tox / Test with tox (3.10) (pull_request) Failing after 3s
Test with tox / Test with tox (3.11) (pull_request) Failing after 0s
Test with tox / Test with tox (3.12) (pull_request) Failing after 0s
Build Project / Build Project (3.10) (pull_request) Successful in 3m3s
2026-04-02 10:52:31 -04:00
e1025794a8 Fixed overwrite issue 2026-04-02 10:52:17 -04:00
cfa1da9f4d Linting
Some checks failed
Build Project / Build Project (3.12) (pull_request) Failing after 1s
Test with tox / Test with tox (3.11) (pull_request) Failing after 1s
Test with tox / Test with tox (3.12) (pull_request) Failing after 1s
Build Sphinx Docs Set / Build Docs (pull_request) Successful in 46s
Build Project / Build Project (3.10) (pull_request) Successful in 7m7s
Test with tox / Test with tox (3.10) (pull_request) Failing after 13m42s
Build Project / Build Project (3.11) (pull_request) Successful in 4m31s
2026-04-02 10:37:42 -04:00
0e3e022084 Updated poetry.lock 2026-04-02 10:35:21 -04:00
F fordg1
5d909c4a22 Update to be accurate to ria toolkit
Some checks failed
Build Sphinx Docs Set / Build Docs (pull_request) Successful in 14m18s
Build Project / Build Project (3.10) (pull_request) Successful in 5m4s
Test with tox / Test with tox (3.10) (pull_request) Failing after 47s
Build Project / Build Project (3.11) (pull_request) Successful in 1m16s
Build Project / Build Project (3.12) (pull_request) Successful in 1m16s
Test with tox / Test with tox (3.11) (pull_request) Failing after 34s
Test with tox / Test with tox (3.12) (pull_request) Failing after 34s
2026-03-31 15:27:45 -04:00
F fordg1
5cfced8855 Fix merge conflicts and port all imports from utils to ria_toolkit_oss
Some checks failed
Build Sphinx Docs Set / Build Docs (pull_request) Failing after 1s
Build Project / Build Project (3.10) (pull_request) Failing after 1s
Build Project / Build Project (3.11) (pull_request) Failing after 1s
Build Project / Build Project (3.12) (pull_request) Failing after 1s
Test with tox / Test with tox (3.10) (pull_request) Failing after 1s
Test with tox / Test with tox (3.11) (pull_request) Failing after 1s
Test with tox / Test with tox (3.12) (pull_request) Failing after 1s
Resolves unresolved merge conflict markers left in committed files across
the annotations, view, data, and CLI packages. Updates all remaining
imports from the old utils.* namespace to ria_toolkit_oss.datatypes,
ria_toolkit_oss.io, and ria_toolkit_oss.view equivalents.
2026-03-31 15:16:32 -04:00
F fordg1
ee2ce3b1f4 Merge branch 'annotationsfix' of https://riahub.ai/qoherent/ria-toolkit-oss into annotationsfix
Some checks failed
Build Sphinx Docs Set / Build Docs (pull_request) Failing after 1s
Build Project / Build Project (3.10) (pull_request) Failing after 1s
Build Project / Build Project (3.11) (pull_request) Failing after 1s
Build Project / Build Project (3.12) (pull_request) Failing after 1s
Test with tox / Test with tox (3.10) (pull_request) Failing after 1s
Test with tox / Test with tox (3.11) (pull_request) Failing after 1s
Test with tox / Test with tox (3.12) (pull_request) Failing after 1s
2026-03-31 14:56:36 -04:00
F fordg1
5b1c51797b logos 2026-03-31 14:54:27 -04:00
F fordg1
2bb2d9d5a7 Removing logos
Some checks failed
Build Sphinx Docs Set / Build Docs (pull_request) Failing after 1s
Build Project / Build Project (3.10) (pull_request) Failing after 1s
Build Project / Build Project (3.11) (pull_request) Failing after 1s
Build Project / Build Project (3.12) (pull_request) Failing after 1s
Test with tox / Test with tox (3.10) (pull_request) Failing after 1s
Test with tox / Test with tox (3.11) (pull_request) Failing after 1s
Test with tox / Test with tox (3.12) (pull_request) Failing after 1s
2026-03-31 13:48:38 -04:00
F fordg1
11d9532b5c Port annotation system from utils and fix ria package imports
Annotations package (new):
- Add threshold_qualifier with 3-pass hysteresis detector (Pass 1: strong
  bursts, Pass 2: weak residual bursts, Pass 3: macro-window faint burst
  detection), auto window_size scaled to 1ms, channel selection, and
  stable noise_floor baseline throughout
- Add energy_detector, cusum_annotator, parallel_signal_separator,
  qualify_slice, signal_isolation, annotation_transforms
- Add __init__.py exporting the four functions used by the CLI
- Fix all imports from utils.data → ria_toolkit_oss.datatypes

CLI annotate command (new):
- Port full annotate CLI from utils including list, add, remove, clear,
  energy, cusum, threshold, and separate subcommands
- Fix imports from utils.* → ria_toolkit_oss.* and utils_cli.* →
  ria_toolkit_oss_cli.*
- Safe overwrite logic: _annotated files always writable, originals
  protected; --overwrite writes in-place only on _annotated inputs

CLI view command:
- Add 'annotations' as a valid --type, wiring view_annotations from
  view_signal

view_signal.py:
- Add view_annotations function with blue/purple alternating palette and
  threshold %-sorted drawing order (lower % renders on top)

recording.py (datatypes):
- Fix lazy imports in to_wav() and to_blue() from utils.io → ria_toolkit_oss.io

io/recording.py:
- Add compatibility shim in from_npy to remap utils.data.annotation.Annotation
  to ria_toolkit_oss.datatypes.annotation.Annotation when loading .npy files
  pickled by the utils package
2026-03-31 13:34:00 -04:00
Mmuq
e41f061caa Merge branch 'annotationsfix' of https://riahub.ai/qoherent/ria-toolkit-oss into annotationsfix 2026-02-23 14:14:16 -05:00
Mmuq
16ac8dbfb6 updated annotations from utils to oss 2026-02-23 14:12:34 -05:00
af3ae03baf Moving annotate into CLI 2026-02-23 14:09:42 -05:00
5c0c20619f Moving over from utils 2026-02-23 14:00:59 -05:00
4ee8ee5fe0 Moving from utils 2026-02-23 14:00:06 -05:00
f7eedfa2bd Annotate added to cli 2026-02-23 13:48:46 -05:00
fc6a1824a5 Added change log for future code from utils 2026-02-20 16:38:27 -05:00