annotationsfix #19
No reviewers
Labels
No Label
CI/CD 🛠️
WIP 🚧
bug 🐞
code quality 🧹
data collection 🗃️
dependency 📦
do not merge 🚫
documentation 📝
duplicate 🔄
enhancement ✨
good first issue 🌱
help wanted 👋
inference 🧠
invalid 🛑
machine learning 🚀
priority
high🔥
priority
low 🍃
priority
medium 🌟
quantum ⚛️
question ❓
radio 📡
sprintable 🏃♂️
test 🧪
wont fix ❌
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: qoherent/ria-toolkit-oss#19
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "annotationsfix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +49,4 @@from ria_toolkit_oss.datatypes import Annotation, Recordingdef _find_ranges(indices, max_gap):One of the pytests failed because the starting point for an annotation wasn't within the expected range. I checked what the annotation looked like (image attached), and the range does look to be too wide. I think we need to take another look at the threshold qualifier and how it determines the range
Summary
residual_powerinstead ofsmoothed_power, and the Pass 2 mask now has awindow_sizeguard band around Pass 1 ranges (mirrors existing Pass 3 behavior)utils.data→ria_toolkit_oss.datatypes)view.pyfixes: indentation correction inVISUALIZATION_TYPESand--type annotate/--type annotationCLI aliases addedContext
OSS was last synced from utils on Feb 23 2026, before the major improvements. The spillover bug was independently reproduced on the utils side after merge and fixed there first — this PR brings OSS fully in line with that fixed state. Note: a remote version of
threshold_qualifier.pywithout the spillover fix was present on this branch and was overridden during merge resolution.Files changed
annotations/threshold_qualifier.py— full port + spillover fixannotations/annotation_transforms.py— import fixannotations/cusum_annotator.py— import fixannotations/energy_detector.py— import fixannotations/parallel_signal_separator.py— import fixannotations/qualify_slice.py— import fixannotations/signal_isolation.py— import fixria_toolkit_oss_cli/ria_toolkit_oss/view.py— indentation + CLI aliasesThe updates to annotations all look good