qoherent/modrec-workflow
14
0
Fork 1
Code Issues 1 Pull Requests Workflows Packages Projects Releases 1 Wiki Activity

Documentation and formatting updates #1

Merged
Liyux merged 12 commits from michael-review into main 2025-07-08 10:50:41 -04:00
Conversation 0 Commits 12 Files Changed 18 +951 -184
michael commented 2025-07-07 12:27:33 -04:00
Owner
Copy Link

Documentation and formatting updates:

  • Updates to project README.
  • Adding project health files (LICENSE and SECURITY.md)
  • A few minor formatting changes throughout
  • A few typo fixes, removal of unused code, cleanup of shadowed variables, and fixed import ordering with isort.

Note: These changes have not been tested.

Documentation and formatting updates: - Updates to project README. - Adding project health files (`LICENSE` and `SECURITY.md`) - A few minor formatting changes throughout - A few typo fixes, removal of unused code, cleanup of shadowed variables, and fixed import ordering with isort. **Note:** These changes have not been tested.
michael added 8 commits 2025-07-07 12:27:33 -04:00
Removing some unused code and some shadowing
Some checks failed
Modulation Recognition Demo / ria-demo (pull_request) Failing after 22s
Details
53d0552fd4
michael requested review from Liyux 2025-07-07 12:27:38 -04:00
michael added 1 commit 2025-07-07 12:30:20 -04:00
Removing general config section, this no longer exists in app.yaml
Some checks failed
Modulation Recognition Demo / ria-demo (pull_request) Failing after 2m7s
Details
2c069cc517
Liyux added 1 commit 2025-07-08 09:26:28 -04:00
fixed plotting imports/removed unused imports
Some checks failed
Modulation Recognition Demo / ria-demo (pull_request) Failing after 2m15s
Details
5cbed47924
Liyux added 1 commit 2025-07-08 09:37:57 -04:00
fixed profiling imports as well as convert_to_onnx imports
All checks were successful
Modulation Recognition Demo / ria-demo (pull_request) Successful in 2m32s
Details
1b54b6f925
Liyux added 1 commit 2025-07-08 09:44:55 -04:00
added a wheel file as a fallback for installation
All checks were successful
Modulation Recognition Demo / ria-demo (pull_request) Successful in 2m53s
Details
8ac05ac981
Liyux changed title from Documentation and formatting updates to WIP: Documentation and formatting updates 2025-07-08 09:45:33 -04:00
Liyux approved these changes 2025-07-08 09:47:04 -04:00
Liyux left a comment
Collaborator
Copy Link

Everything looks good Michael, I fixed some importing issues, and added the wheel file as a fallback for installation. Tested it out on my end and now everything runs fine now. You can merge whenever!

Everything looks good Michael, I fixed some importing issues, and added the wheel file as a fallback for installation. Tested it out on my end and now everything runs fine now. You can merge whenever!
Liyux changed title from WIP: Documentation and formatting updates to Documentation and formatting updates 2025-07-08 10:44:07 -04:00
Liyux merged commit 9979d84e29 into main 2025-07-08 10:50:41 -04:00
michael deleted branch michael-review 2025-07-10 11:50:08 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Liyux
Labels
Clear labels
  
CI/CD 🛠️

This issue relates to our automated testing, building, and publishing processes

  
WIP 🚧

Someone is currently worked on this issue

  
bug 🐞

There is a problem, error, or unexpected behaviour

  
code quality 🧹

This issues pertains to code quality improvements or tech debt reduction

  
data collection 🗃️

This issue involves machine learning data collection or filing

  
dependency 📦

This issue pertains to dependency changes or deprecation warnings

  
do not merge 🚫

This pull request is not to be merged

  
documentation 📝

Improvements or additions to documentation or tutorials

  
duplicate 🔄

This issue or pull request already exists

  
enhancement ✨

This issue is important and will require attention soon, but does not pose any immediate risks

  
good first issue 🌱

A good first issue for newcomers

  
help wanted 👋

Additional development support is required

  
inference 🧠

This issue involves designing or improving inference solutions

  
invalid 🛑

Something is wrong with this issue or it not does conform to project guidelines

  
machine learning 🚀

This issue pertains to and may require expertise in machine learning

  
priority
high🔥
This issue is critical and requires immediate attention to prevent further consequence or escalation

  
priority
low 🍃

  
priority
medium 🌟
This issue is important and will require attention soon, but does not pose any immediate risks

  
quantum ⚛️

This issue pertains to and may require expertise in quantum technology

  
question ❓

Additional information is required

  
radio 📡

This issue involves radio interface components and may requires access to radio hardware

  
sprintable 🏃‍♂️

This issue could be resolved in a single sprint

  
test 🧪

This issue pertains to our testing efforts

  
wont fix ❌

We've chosen not to address this issue

No Label
CI/CD 🛠️
WIP 🚧
bug 🐞
code quality 🧹
data collection 🗃️
dependency 📦
do not merge 🚫
documentation 📝
duplicate 🔄
enhancement ✨
good first issue 🌱
help wanted 👋
inference 🧠
invalid 🛑
machine learning 🚀
priority
high🔥
priority
low 🍃
priority
medium 🌟
quantum ⚛️
question ❓
radio 📡
sprintable 🏃‍♂️
test 🧪
wont fix ❌
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: qoherent/modrec-workflow#1
No description provided.
Delete Branch "michael-review"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?