Ria Composer Support #23

Merged

benchinnery merged 3 commits from zfp-oss into main 2026-04-17 10:11:56 -04:00

Conversation 0 Commits 3 Files Changed 9 +1571 -2

benchinnery commented 2026-04-17 09:44:25 -04:00

Owner

Copy Link

Adds SDR-to-SDR transmission support via a three-machine architecture (hub supervisor → Rx agent → Tx machine over SSH + ZMQ), along with a full test suite for the new remote control module.

ria_toolkit_oss/remote_control/ (new package)
remote_transmitter.py — Server-side ZMQ REP socket server that runs on the Tx machine. Accepts JSON-RPC commands (set_radio, init_tx, transmit, stop) and dispatches them to the appropriate SDR driver (PlutoSDR, USRP, HackRF, BladeRF) via dynamic import.
remote_transmitter_controller.py — Client-side controller that runs on the Rx machine. SSH-es into the Tx machine to start the ZMQ server, then sends commands over ZMQ. transmit_async() starts transmission in a background thread so the Rx machine can record concurrently.

orchestration/campaign.py
TransmitterConfig gains an sdr_remote: Optional[dict] field, parsed from the campaign config. Holds SSH credentials and SDR identifier for remote Tx machines.

orchestration/executor.py
CampaignExecutor now handles control_method: "sdr_remote" transmitters:
_init_remote_tx_controllers() — opens SSH + ZMQ connections and calls set_radio() for each remote Tx before the campaign loop starts.
_start_transmitter() — calls init_tx() then transmit_async(duration + 1s buffer) so the Tx is running before the Rx starts recording.
_stop_transmitter() — calls wait_transmit(timeout=duration + 10s) to synchronise after recording.
_close_remote_tx_controllers() — tears down all connections in the finally block, even if one fails.

Tests (tests/remote_control/, 88 tests)
test_remote_transmitter.py — all SDR aliases, guards, dispatcher, response envelope
test_remote_transmitter_controller.py — SSH/ZMQ setup, message format, error handling, transmit_async non-blocking guarantee, teardown
test_sdr_remote_integration.py — TransmitterConfig parsing, CampaignConfig round-trip (dict and YAML), executor init/start/stop/close for single and multiple controllers, mixed campaigns, exact timing buffers

All SDR driver patches use sys.modules injection so the tests run in any environment regardless of which hardware packages are installed. paramiko and zmq are lazy-imported at connection time rather than at module import time.

Adds SDR-to-SDR transmission support via a three-machine architecture (hub supervisor → Rx agent → Tx machine over SSH + ZMQ), along with a full test suite for the new remote control module. **ria_toolkit_oss/remote_control/ (new package)** remote_transmitter.py — Server-side ZMQ REP socket server that runs on the Tx machine. Accepts JSON-RPC commands (set_radio, init_tx, transmit, stop) and dispatches them to the appropriate SDR driver (PlutoSDR, USRP, HackRF, BladeRF) via dynamic import. remote_transmitter_controller.py — Client-side controller that runs on the Rx machine. SSH-es into the Tx machine to start the ZMQ server, then sends commands over ZMQ. transmit_async() starts transmission in a background thread so the Rx machine can record concurrently. **orchestration/campaign.py** TransmitterConfig gains an sdr_remote: Optional[dict] field, parsed from the campaign config. Holds SSH credentials and SDR identifier for remote Tx machines. **orchestration/executor.py** CampaignExecutor now handles control_method: "sdr_remote" transmitters: _init_remote_tx_controllers() — opens SSH + ZMQ connections and calls set_radio() for each remote Tx before the campaign loop starts. _start_transmitter() — calls init_tx() then transmit_async(duration + 1s buffer) so the Tx is running before the Rx starts recording. _stop_transmitter() — calls wait_transmit(timeout=duration + 10s) to synchronise after recording. _close_remote_tx_controllers() — tears down all connections in the finally block, even if one fails. **Tests (tests/remote_control/, 88 tests)** test_remote_transmitter.py — all SDR aliases, guards, dispatcher, response envelope test_remote_transmitter_controller.py — SSH/ZMQ setup, message format, error handling, transmit_async non-blocking guarantee, teardown test_sdr_remote_integration.py — TransmitterConfig parsing, CampaignConfig round-trip (dict and YAML), executor init/start/stop/close for single and multiple controllers, mixed campaigns, exact timing buffers All SDR driver patches use sys.modules injection so the tests run in any environment regardless of which hardware packages are installed. paramiko and zmq are lazy-imported at connection time rather than at module import time.

benchinnery added 1 commit 2026-04-17 09:44:25 -04:00

ria composer support efc0948110

benchinnery added 1 commit 2026-04-17 10:04:22 -04:00

test suite 638fe5df1f

G gillian approved these changes 2026-04-17 10:05:35 -04:00

benchinnery requested review from gillian 2026-04-17 10:11:15 -04:00

benchinnery added 1 commit 2026-04-17 10:11:41 -04:00

Merge remote-tracking branch 'origin' into zfp-oss 83515d6e3f

benchinnery merged commit 6fb73c1daa into main 2026-04-17 10:11:56 -04:00

benchinnery referenced this issue from a commit 2026-04-17 10:11:58 -04:00

Merge pull request 'Ria Composer Support' (#23) from zfp-oss into main

Sign in to join this conversation.

Reviewers

No reviewers

Ggillian

Labels

Clear labels

  

CI/CD 🛠️

This issue relates to our automated testing, building, and publishing processes

  

WIP 🚧

Someone is currently worked on this issue

  

bug 🐞

There is a problem, error, or unexpected behaviour

  

code quality 🧹

This issues pertains to code quality improvements or tech debt reduction

  

data collection 🗃️

This issue involves machine learning data collection or filing

  

dependency 📦

This issue pertains to dependency changes or deprecation warnings

  

do not merge 🚫

This pull request is not to be merged

  

documentation 📝

Improvements or additions to documentation or tutorials

  

duplicate 🔄

This issue or pull request already exists

  

enhancement ✨

This issue is important and will require attention soon, but does not pose any immediate risks

  

good first issue 🌱

A good first issue for newcomers

  

help wanted 👋

Additional development support is required

  

inference 🧠

This issue involves designing or improving inference solutions

  

invalid 🛑

Something is wrong with this issue or it not does conform to project guidelines

  

machine learning 🚀

This issue pertains to and may require expertise in machine learning

  

priority

high🔥

This issue is critical and requires immediate attention to prevent further consequence or escalation

  

priority

low 🍃

  

priority

medium 🌟

This issue is important and will require attention soon, but does not pose any immediate risks

  

quantum ⚛️

This issue pertains to and may require expertise in quantum technology

  

question ❓

Additional information is required

  

radio 📡

This issue involves radio interface components and may requires access to radio hardware

  

sprintable 🏃‍♂️

This issue could be resolved in a single sprint

  

test 🧪

This issue pertains to our testing efforts

  

wont fix ❌

We've chosen not to address this issue

No Label

CI/CD 🛠️

WIP 🚧

bug 🐞

code quality 🧹

data collection 🗃️

dependency 📦

do not merge 🚫

documentation 📝

duplicate 🔄

enhancement ✨

good first issue 🌱

help wanted 👋

inference 🧠

invalid 🛑

machine learning 🚀

priority

high🔥

priority

low 🍃

priority

medium 🌟

quantum ⚛️

question ❓

radio 📡

sprintable 🏃‍♂️

test 🧪

wont fix ❌

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

G

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: qoherent/ria-toolkit-oss#23

No description provided.